fix(tag): update state to clear form on success (#25934)

apache · Nov 15, 2023 · aee94b3 · aee94b3
1 parent 63b8172
commit aee94b3
Showing 1 changed file with 13 additions and 8 deletions.
diff --git a/superset-frontend/src/features/tags/TagModal.tsx b/superset-frontend/src/features/tags/TagModal.tsx
@@ -88,6 +88,14 @@ const TagModal: React.FC<TagModalProps> = ({
     setSavedQueriesToTag([]);
   };
 
+  const clearTagForm = () => {
+    setTagName('');
+    setDescription('');
+    setDashboardsToTag([]);
+    setChartsToTag([]);
+    setSavedQueriesToTag([]);
+  };
+
   useEffect(() => {
     const resourceMap: { [key: string]: TaggableResourceOption[] } = {
       [TaggableResources.Dashboard]: [],
@@ -225,7 +233,9 @@ const TagModal: React.FC<TagModalProps> = ({
       })
         .then(({ json = {} }) => {
           refreshData();
+          clearTagForm();
           addSuccessToast(t('Tag updated'));
+          onHide();
         })
         .catch(err => {
           addDangerToast(err.message || 'Error Updating Tag');
@@ -241,24 +251,19 @@ const TagModal: React.FC<TagModalProps> = ({
       })
         .then(({ json = {} }) => {
           refreshData();
+          clearTagForm();
           addSuccessToast(t('Tag created'));
+          onHide();
         })
         .catch(err => addDangerToast(err.message || 'Error Creating Tag'));
     }
-    onHide();
   };
 
   return (
     <Modal
       title={modalTitle}
       onHide={() => {
-        if (clearOnHide) {
-          setTagName('');
-          setDescription('');
-          setDashboardsToTag([]);
-          setChartsToTag([]);
-          setSavedQueriesToTag([]);
-        }
+        if (clearOnHide) clearTagForm();
         onHide();
       }}
       show={show}