remove default value for timeseries_limit

apache · Sep 15, 2021 · 89819a0 · 89819a0
1 parent dad75b9
commit 89819a0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -953,7 +953,7 @@ def get_sqla_query(  # pylint: disable=too-many-arguments,too-many-locals,too-ma
         series_limit_metric: Optional[Metric] = None,
         row_limit: Optional[int] = None,
         row_offset: Optional[int] = None,
-        timeseries_limit: int = 15,
+        timeseries_limit: Optional[int] = None,
         timeseries_limit_metric: Optional[Metric] = None,
     ) -> SqlaQuery:
         """Querying any sqla table from this common interface"""

diff --git a/tests/integration_tests/model_tests.py b/tests/integration_tests/model_tests.py
@@ -418,6 +418,7 @@ def query_with_expr_helper(self, is_timeseries, inner_join=True):
             from_dttm=None,
             to_dttm=None,
             extras=dict(time_grain_sqla="P1Y"),
+            series_limit=15 if inner_join and is_timeseries else None,
         )
         qr = tbl.query(query_obj)
         self.assertEqual(qr.status, QueryStatus.SUCCESS)