fix: typing difficulties

apache · Aug 9, 2021 · 45888ea · 45888ea
1 parent 747677e
commit 45888ea
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/superset/config.py b/superset/config.py
@@ -51,7 +51,6 @@
 logger = logging.getLogger(__name__)
 
 if TYPE_CHECKING:
-    from tasks.cache import Strategy
     from flask_appbuilder.security.sqla import models  # pylint: disable=unused-import
 
     from superset.connectors.sqla.models import (  # pylint: disable=unused-import
@@ -706,7 +705,7 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 CELERY_CONFIG = CeleryConfig  # pylint: disable=invalid-name
 
 # Additional Caching strategies to be used in the CELERYBEAT_SCHEDULE config
-EXTRA_CACHING_STRATEGIES: List[Strategy] = []
+EXTRA_CACHING_STRATEGIES = []
 
 # Set celery config to None to disable all the above configuration
 # CELERY_CONFIG = None

diff --git a/superset/tasks/cache.py b/superset/tasks/cache.py
@@ -252,7 +252,7 @@ def get_urls(self) -> List[str]:
         return urls
 
 
-strategies : List[Strategy] = [DummyStrategy, TopNDashboardsStrategy, DashboardTagsStrategy]
+strategies = [DummyStrategy, TopNDashboardsStrategy, DashboardTagsStrategy]
 
 
 @celery_app.task(name="cache-warmup")
@@ -268,7 +268,7 @@ def cache_warmup(
     logger.info("Loading strategy")
     class_ = None
 
-    extra_strategies: List[Strategy] = app.config["EXTRA_CACHING_STRATEGIES"]
+    extra_strategies = app.config["EXTRA_CACHING_STRATEGIES"]
     for class_ in strategies + extra_strategies:
         if class_.name == strategy_name:  # type: ignore
             break