Add warnings if feature flags are read before initialization.

apache · Aug 25, 2022 · 20298a5 · 20298a5
1 parent 17ad0d8
commit 20298a5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
@@ -84,5 +84,13 @@ declare global {
 }
 
 export function isFeatureEnabled(feature: FeatureFlag) {
-  return window && window.featureFlags && !!window.featureFlags[feature];
+  try {
+    return !!window.featureFlags[feature];
+  } catch (error) {
+    // eslint-disable-next-line no-console
+    console.error(`Failed to query feature flag ${feature} (see error below)`);
+    // eslint-disable-next-line no-console
+    console.error(error);
+    return false;
+  }
 }
diff --git a/superset-frontend/src/featureFlags.ts b/superset-frontend/src/featureFlags.ts
@@ -28,5 +28,13 @@ export function initFeatureFlags(featureFlags: FeatureFlagMap) {
 }
 
 export function isFeatureEnabled(feature: FeatureFlag) {
-  return window && window.featureFlags && !!window.featureFlags[feature];
+  try {
+    return !!window.featureFlags[feature];
+  } catch (error) {
+    // eslint-disable-next-line no-console
+    console.error(`Failed to query feature flag ${feature} (see error below)`);
+    // eslint-disable-next-line no-console
+    console.error(error);
+    return false;
+  }
 }