Skip to content

Commit

Permalink
Piling up
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Apr 13, 2017
1 parent aa52ac3 commit 179eecb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
4 changes: 3 additions & 1 deletion superset/connectors/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,11 @@ def get_query_str(self, query_obj):
def query(self, query_obj):
"""Executes the query and returns a dataframe
query_obj is a dictionary representing Superset's query interface
query_obj is a dictionary representing Superset's query interface.
Should return a ``superset.models.helpers.QueryResult``
"""
raise NotImplementedError()

def values_for_column(self, column_name, limit=10000):
"""Given a column, returns an iterable of distinct values
Expand Down
3 changes: 2 additions & 1 deletion superset/connectors/druid/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,8 @@ def recursive_get_fields(_conf):
def query(self, query_obj):
qry_start_dttm = datetime.now()
client = self.cluster.get_pydruid_client()
query_str = self.get_query_str(client=client, query_obj=query_obj, phase=2)
query_str = self.get_query_str(
client=client, query_obj=query_obj, phase=2)
df = client.export_pandas()

if df is None or df.size == 0:
Expand Down

0 comments on commit 179eecb

Please sign in to comment.