feat(time-comparison-table): change "Display Columns" Text for an Icon

apache · Apr 23, 2024 · 1677b54 · 1677b54
1 parent 608f47e
commit 1677b54
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx b/superset-frontend/plugins/plugin-chart-table/src/DataTable/DataTable.tsx
@@ -380,11 +380,7 @@ export default typedMemo(function DataTable<D extends object>({
               ) : null}
             </div>
             {searchInput ? (
-              <div
-                className={
-                  renderTimeComparisonDropdown ? 'col-sm-5' : 'col-sm-6'
-                }
-              >
+              <div className="col-sm-6">
                 <GlobalFilter<D>
                   searchInput={
                     typeof searchInput === 'boolean' ? undefined : searchInput
@@ -396,7 +392,10 @@ export default typedMemo(function DataTable<D extends object>({
               </div>
             ) : null}
             {renderTimeComparisonDropdown ? (
-              <div className="col-sm-2" style={{ float: 'right' }}>
+              <div
+                className="col-sm-1"
+                style={{ float: 'right', marginTop: '6px' }}
+              >
                 {renderTimeComparisonDropdown()}
               </div>
             ) : null}

diff --git a/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx b/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx
@@ -56,6 +56,7 @@ import {
   DownOutlined,
   MinusCircleOutlined,
   PlusCircleOutlined,
+  TableOutlined,
 } from '@ant-design/icons';
 
 import { isEmpty } from 'lodash';
@@ -578,7 +579,7 @@ export default function TableChart<D extends DataRecord = DataRecord>(
         trigger={['click']}
       >
         <span>
-          {t('Display columns')} <DownOutlined />
+          <TableOutlined /> <DownOutlined />
         </span>
       </Dropdown>
     );