chore: remove unused eslintrc

apache · Jan 5, 2022 · 0eac2ea · 0eac2ea
1 parent 97a78d3
commit 0eac2ea
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 129 deletions.
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
@@ -136,24 +136,6 @@ module.exports = {
         'no-nested-ternary': 0,
         'no-prototype-builtins': 0,
         'no-restricted-properties': 0,
-        'no-restricted-imports': [
-          'warn',
-          {
-            paths: [
-              {
-                name: 'antd',
-                message:
-                  'Please import Ant components from the index of common/components',
-              },
-              {
-                name: '@superset-ui/core',
-                importNames: ['supersetTheme'],
-                message:
-                  'Please use the theme directly from the ThemeProvider rather than importing supersetTheme.',
-              },
-            ],
-          },
-        ],
         'no-shadow': 0, // re-enable up for discussion
         'no-use-before-define': 0, // disabled temporarily
         'padded-blocks': 0,
@@ -287,14 +269,20 @@ module.exports = {
     'no-prototype-builtins': 0,
     'no-restricted-properties': 0,
     'no-restricted-imports': [
-      'error',
+      'warn',
       {
         paths: [
           {
             name: 'antd',
             message:
               'Please import Ant components from the index of common/components',
           },
+          {
+            name: '@superset-ui/core',
+            importNames: ['supersetTheme'],
+            message:
+              'Please use the theme directly from the ThemeProvider rather than importing supersetTheme.',
+          },
         ],
       },
     ],

diff --git a/superset-frontend/src/common/components/.eslintrc b/superset-frontend/src/common/components/.eslintrc
diff --git a/superset-frontend/src/components/.eslintrc b/superset-frontend/src/components/.eslintrc
diff --git a/superset-frontend/src/dashboard/.eslintrc b/superset-frontend/src/dashboard/.eslintrc
diff --git a/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx b/superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
@@ -115,8 +115,9 @@ const FilterFocusHighlight = React.forwardRef(
       dashboardFilters,
     );
     const focusedNativeFilterId = nativeFilters.focusedFilterId;
-    if (!(focusedFilterScope || focusedNativeFilterId))
+    if (!(focusedFilterScope || focusedNativeFilterId)) {
       return <div ref={ref} {...otherProps} />;
+    }
 
     // we use local styles here instead of a conditionally-applied class,
     // because adding any conditional class to this container

diff --git a/superset-frontend/src/middleware/asyncEvent.ts b/superset-frontend/src/middleware/asyncEvent.ts
@@ -16,7 +16,12 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import { ensureIsArray, makeApi, SupersetClient } from '@superset-ui/core';
+import {
+  ensureIsArray,
+  makeApi,
+  SupersetClient,
+  logging,
+} from '@superset-ui/core';
 import { SupersetError } from 'src/components/ErrorMessage/types';
 import { FeatureFlag, isFeatureEnabled } from '../featureFlags';
 import {
@@ -82,7 +87,7 @@ export const init = (appConfig?: AppConfig) => {
       config = bootstrapData?.common?.conf;
     } else {
       config = {};
-      console.warn('asyncEvent: app config data not found');
+      logging.warn('asyncEvent: app config data not found');
     }
   }
   transport = config.GLOBAL_ASYNC_QUERIES_TRANSPORT || TRANSPORT_POLLING;
@@ -91,7 +96,7 @@ export const init = (appConfig?: AppConfig) => {
   try {
     lastReceivedEventId = localStorage.getItem(LOCALSTORAGE_KEY);
   } catch (err) {
-    console.warn('Failed to fetch last event Id from localStorage');
+    logging.warn('Failed to fetch last event Id from localStorage');
   }
 
   if (transport === TRANSPORT_POLLING) {
@@ -132,7 +137,7 @@ export const waitForAsyncData = async (asyncResponse: AsyncEvent) =>
           break;
         }
         default: {
-          console.warn('received event with status', asyncEvent.status);
+          logging.warn('received event with status', asyncEvent.status);
         }
       }
       removeListener(jobId);
@@ -171,7 +176,7 @@ const setLastId = (asyncEvent: AsyncEvent) => {
   try {
     localStorage.setItem(LOCALSTORAGE_KEY, lastReceivedEventId as string);
   } catch (err) {
-    console.warn('Error saving event Id to localStorage', err);
+    logging.warn('Error saving event Id to localStorage', err);
   }
 };
 
@@ -182,7 +187,7 @@ const loadEventsFromApi = async () => {
       const { result: events } = await fetchEvents(eventArgs);
       if (events && events.length) await processEvents(events);
     } catch (err) {
-      console.warn(err);
+      logging.warn(err);
     }
   }
 
@@ -210,7 +215,7 @@ export const processEvents = async (events: AsyncEvent[]) => {
         }, RETRY_DELAY * retriesByJobId[jobId]);
       } else {
         delete retriesByJobId[jobId];
-        console.warn('listener not found for job_id', asyncEvent.job_id);
+        logging.warn('listener not found for job_id', asyncEvent.job_id);
       }
     }
     setLastId(asyncEvent);
@@ -229,7 +234,7 @@ const wsConnect = (): void => {
   ws = new WebSocket(url);
 
   ws.addEventListener('open', event => {
-    console.log('WebSocket connected');
+    logging.log('WebSocket connected');
     clearTimeout(wsConnectTimeout);
     wsConnectRetries = 0;
   });
@@ -240,7 +245,7 @@ const wsConnect = (): void => {
       if (wsConnectRetries <= wsConnectMaxRetries) {
         wsConnect();
       } else {
-        console.warn('WebSocket not available, falling back to async polling');
+        logging.warn('WebSocket not available, falling back to async polling');
         loadEventsFromApi();
       }
     }, wsConnectErrorDelay);
@@ -257,7 +262,7 @@ const wsConnect = (): void => {
       events = [JSON.parse(event.data)];
       await processEvents(events);
     } catch (err) {
-      console.warn(err);
+      logging.warn(err);
     }
   });
 };