Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5517 Fixes <s:debug/> to be compatible with allowlist capability #1187

Merged
merged 2 commits into from
Jan 21, 2025
Merged

WW-5517 Fixes <s:debug/> to be compatible with allowlist capability #1187

merged 2 commits into from
Jan 21, 2025

Conversation

lukaszlenart
Copy link
Member

@lukaszlenart lukaszlenart marked this pull request as draft January 18, 2025 18:30
@lukaszlenart lukaszlenart force-pushed the fix/WW-5517-debug branch 5 times, most recently from 5b05621 to 940b0ea Compare January 18, 2025 20:40
@lukaszlenart lukaszlenart marked this pull request as ready for review January 18, 2025 21:04
kusalk
kusalk approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@kusalk kusalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! - doesn't look like the allowlist fixes are covered by any tests but given this is for debugging purposes it's not critical

core/src/test/java/org/apache/struts2/interceptor/debugging/DebuggingInterceptorTest.java Outdated Show resolved Hide resolved
core/src/test/java/org/apache/struts2/views/jsp/ui/DebugTagTest.java Outdated Show resolved Hide resolved
@lukaszlenart
Copy link
Member Author

LGTM! - doesn't look like the allowlist fixes are covered by any tests but given this is for debugging purposes it's not critical

You mean to check if a specific class has been added to allowlist after debugging?

@lukaszlenart
Copy link
Member Author

Done

@lukaszlenart lukaszlenart force-pushed the fix/WW-5517-debug branch 2 times, most recently from 43a8ce6 to edee6e3 Compare January 20, 2025 07:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@lukaszlenart lukaszlenart added this to the 7.0.1 milestone Jan 21, 2025
kusalk
kusalk approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@kusalk kusalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lukaszlenart lukaszlenart merged commit 4e80f26 into main Jan 21, 2025
8 checks passed
@lukaszlenart lukaszlenart deleted the fix/WW-5517-debug branch January 21, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusalk kusalk kusalk approved these changes

@rgielen rgielen Awaiting requested review from rgielen

@aleksandr-m aleksandr-m Awaiting requested review from aleksandr-m

@yasserzamani yasserzamani Awaiting requested review from yasserzamani

@sdutry sdutry Awaiting requested review from sdutry

@cnenning cnenning Awaiting requested review from cnenning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszlenart @kusalk