Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-11926][SQL] unify GetStructField and GetInternalRowField #9909

Closed
wants to merge 3 commits into from

Conversation

cloud-fan
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 23, 2015

Test build #46531 has finished for PR 9909 at commit ec40d23.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None)\n * case class PrettyAttribute(name: String, dataType: DataType = NullType)\n

@cloud-fan
Copy link
Contributor Author

cc @marmbrus

*/
case class GetStructField(child: Expression, field: StructField, ordinal: Int)
case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe comment that the name is only for debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not for debugging, but to keep case preserving. For example, if we try to get field yEAr from <year: int, month: int>, we should pass yEAr to GetStructField. And it's also consistent with the original behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, then document that :)

@marmbrus
Copy link
Contributor

Thanks for cleaning this up! LGTM pending tests.

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #46568 has finished for PR 9909 at commit 19907cf.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

retest this please.

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #46572 has finished for PR 9909 at commit 19907cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None)\n * case class PrettyAttribute(name: String, dataType: DataType = NullType)\n

@SparkQA
Copy link

SparkQA commented Nov 24, 2015

Test build #46577 has finished for PR 9909 at commit 9d12eb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None)\n * case class PrettyAttribute(name: String, dataType: DataType = NullType)\n

@marmbrus
Copy link
Contributor

Merging to master and 1.6.

@asfgit asfgit closed this in 19530da Nov 24, 2015
asfgit pushed a commit that referenced this pull request Nov 24, 2015
Author: Wenchen Fan <wenchen@databricks.com>

Closes #9909 from cloud-fan/get-struct.

(cherry picked from commit 19530da)
Signed-off-by: Michael Armbrust <michael@databricks.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants