-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11926][SQL] unify GetStructField and GetInternalRowField #9909
Conversation
Test build #46531 has finished for PR 9909 at commit
|
cc @marmbrus |
*/ | ||
case class GetStructField(child: Expression, field: StructField, ordinal: Int) | ||
case class GetStructField(child: Expression, ordinal: Int, name: Option[String] = None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe comment that the name
is only for debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not for debugging, but to keep case preserving. For example, if we try to get field yEAr
from <year: int, month: int>
, we should pass yEAr
to GetStructField
. And it's also consistent with the original behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, then document that :)
Thanks for cleaning this up! LGTM pending tests. |
Test build #46568 has finished for PR 9909 at commit
|
retest this please. |
Test build #46572 has finished for PR 9909 at commit
|
Test build #46577 has finished for PR 9909 at commit
|
Merging to master and 1.6. |
No description provided.