-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11872] Prevent the call to SparkContext#stop() in the listener bus's thread #9852
Conversation
Test build #46376 has finished for PR 9852 at commit
|
@andrewor14 @zsxwing |
@tedyu could you add a unit test? Just to avoid someone breaking it in future. |
Should I add test in StreamingListenerSuite.scala (stopping SparkContext instead of stopping StreamingContext) ? Thanks |
You can add the test to SparkListenerSuite in core |
Test build #46430 has finished for PR 9852 at commit
|
retest this please |
I don't think the above failures were related to my change |
Manually ran org.apache.spark.streaming.CheckpointSuite (with this change) which passed. |
Test build #46445 has finished for PR 9852 at commit
|
LGTM |
@zsxwing @andrewor14 |
… bus's thread This is continuation of SPARK-11761 Andrew suggested adding this protection. See tail of #9741 Author: tedyu <yuzhihong@gmail.com> Closes #9852 from tedyu/master. (cherry picked from commit 8101254) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Merged to master and 1.6. Thanks! |
This is continuation of SPARK-11761
Andrew suggested adding this protection. See tail of #9741