[SPARK-11723] [ML] [Doc] Use LibSVM data source rather than MLUtils.loadLibSVMFile to load DataFrame #9690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| case _ => | ||
| throw new IllegalArgumentException("Algo ${params.algo} not supported.") | ||
| } | ||
| } |
There was a problem hiding this comment.
StringIndexer will cast label column to String automatically and then index, so we don't need this code snippet.
|
Test build #45858 has finished for PR 9690 at commit
|
| @@ -82,7 +82,7 @@ private[libsvm] class LibSVMRelation(val path: String, val numFeatures: Int, val | |||
| * .load("data/mllib/sample_libsvm_data.txt") | |||
| * | |||
| * // Java | |||
| * DataFrame df = sqlContext.read.format("libsvm") | |||
| * DataFrame df = sqlContext.read().format("libsvm") | |||
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2015
…dLibSVMFile to load DataFrame Use LibSVM data source rather than MLUtils.loadLibSVMFile to load DataFrame, include: * Use libSVM data source for all example codes under examples/ml, and remove unused import. * Use libSVM data source for user guides under ml-*** which were omitted by #8697. * Fix bug: We should use ```sqlContext.read().format("libsvm").load(path)``` at Java side, but the API doc and user guides misuse as ```sqlContext.read.format("libsvm").load(path)```. * Code cleanup. mengxr Author: Yanbo Liang <ybliang8@gmail.com> Closes #9690 from yanboliang/spark-11723. (cherry picked from commit 99693fe) Signed-off-by: Xiangrui Meng <meng@databricks.com>
|
LGTM. Merged into master and branch-1.6. Thanks! |
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
…dLibSVMFile to load DataFrame Use LibSVM data source rather than MLUtils.loadLibSVMFile to load DataFrame, include: * Use libSVM data source for all example codes under examples/ml, and remove unused import. * Use libSVM data source for user guides under ml-*** which were omitted by apache#8697. * Fix bug: We should use ```sqlContext.read().format("libsvm").load(path)``` at Java side, but the API doc and user guides misuse as ```sqlContext.read.format("libsvm").load(path)```. * Code cleanup. mengxr Author: Yanbo Liang <ybliang8@gmail.com> Closes apache#9690 from yanboliang/spark-11723.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use LibSVM data source rather than MLUtils.loadLibSVMFile to load DataFrame, include:
sqlContext.read().format("libsvm").load(path)at Java side, but the API doc and user guides misuse assqlContext.read.format("libsvm").load(path).@mengxr