[SPARK-11706][Streaming]Fix the bug that Streaming Python tests cannot report failures #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually tested this patch locally by adding |
| for testcase in testcases: | ||
| sys.stderr.write("[Running %s]\n" % (testcase)) | ||
| tests = unittest.TestLoader().loadTestsFromTestCase(testcase) | ||
| if xmlrunner: | ||
| unittest.main(tests, verbosity=3, |
There was a problem hiding this comment.
unittest.main will call sys.exit after finishing tests, so we should not use it here.
|
Test build #45753 has finished for PR 9669 at commit
|
|
Test build #45759 has finished for PR 9669 at commit
|
|
No surprises. Exposed a lot of test failures. Fixing them |
|
Test build #45776 has finished for PR 9669 at commit
|
| @@ -611,12 +611,15 @@ class CheckpointTests(unittest.TestCase): | |||
| @staticmethod | |||
| def tearDownClass(): | |||
| # Clean up in the JVM just in case there has been some issues in Python API | |||
| jStreamingContextOption = StreamingContext._jvm.SparkContext.getActive() | |||
There was a problem hiding this comment.
StreamingContext doesn't have a static _jvm. It's an instance field.
|
Test build #45784 has finished for PR 9669 at commit
|
|
Merging this to master, 1.6 and 1.5. Thanks @zsxwing for catching this. |
asfgit
pushed a commit
that referenced
this pull request
Nov 13, 2015
…ot report failures This PR just checks the test results and returns 1 if the test fails, so that `run-tests.py` can mark it fail. Author: Shixiong Zhu <shixiong@databricks.com> Closes #9669 from zsxwing/streaming-python-tests. (cherry picked from commit ec80c0c) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
…ot report failures This PR just checks the test results and returns 1 if the test fails, so that `run-tests.py` can mark it fail. Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#9669 from zsxwing/streaming-python-tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just checks the test results and returns 1 if the test fails, so that
run-tests.pycan mark it fail.