[SPARK-10113][SQL] Explicit error message for unsigned Parquet logical types #9646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #45693 has finished for PR 9646 at commit
|
|
cc @liancheng |
|
Would you please rename the PR title to "Explicit error message for unsigned Parquet logical types"? Since this PR doesn't introduce "support" for unsigned types. Otherwise LGTM. Thanks! |
|
This seems fine for now, but its not clear to me why the right answer isn't to read it in as a higher precision signed type. |
|
Merging to master and 1.6 |
asfgit
pushed a commit
that referenced
this pull request
Nov 12, 2015
…l types Parquet supports some unsigned datatypes. However, Since Spark does not support unsigned datatypes, it needs to emit an exception with a clear message rather then with the one saying illegal datatype. Author: hyukjinkwon <gurwls223@gmail.com> Closes #9646 from HyukjinKwon/SPARK-10113. (cherry picked from commit f5a9526) Signed-off-by: Michael Armbrust <michael@databricks.com>
|
@marmbrus That's also an option, but seems somewhat confusing to me. Especially, in this way |
dskrvk
pushed a commit
to dskrvk/spark
that referenced
this pull request
Nov 13, 2015
…l types Parquet supports some unsigned datatypes. However, Since Spark does not support unsigned datatypes, it needs to emit an exception with a clear message rather then with the one saying illegal datatype. Author: hyukjinkwon <gurwls223@gmail.com> Closes apache#9646 from HyukjinKwon/SPARK-10113.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parquet supports some unsigned datatypes. However, Since Spark does not support unsigned datatypes, it needs to emit an exception with a clear message rather then with the one saying illegal datatype.