-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-11445][DOCS]Replaced example code in mllib-ensembles.md using include_example #9407
Conversation
ok to test |
@yinxusen Could you help review this PR? |
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.examples.mllib; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a blank line below here.
@yinxusen Thanks for your comments.Have made the required changes in the files you pointed and others also.Please review. |
Test build #44872 has finished for PR 9407 at commit
|
// $example off$ | ||
|
||
object RandomForestClassificationExample { | ||
def main(args: Array[String]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def main(args: Array[String]): Unit = {
# $example on$ | ||
from pyspark.mllib.tree import GradientBoostedTrees, GradientBoostedTreesModel | ||
from pyspark.mllib.util import MLUtils | ||
# $example off$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blank line
@rishabhbhardwaj One more thing, all of your Python code files have no definition of |
@yinxusen Made the changes.Also ran the python files and they are working fine.Thanks for your inputs.WIll keep these points in mind from next time. |
Test build #44883 has finished for PR 9407 at commit
|
@mengxr LGTM |
… include_example I have made the required changes and tested. Kindly review the changes. Author: Rishabh Bhardwaj <rbnext29@gmail.com> Closes #9407 from rishabhbhardwaj/SPARK-11445. (cherry picked from commit 61a2848) Signed-off-by: Xiangrui Meng <meng@databricks.com>
Merged into master and branch-1.6. Thanks! |
… include_example I have made the required changes and tested. Kindly review the changes. Author: Rishabh Bhardwaj <rbnext29@gmail.com> Closes apache#9407 from rishabhbhardwaj/SPARK-11445.
I have made the required changes and tested.
Kindly review the changes.