[SPARK-8305] [SPARK-8190] [SQL] improve codegen #6755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #34659 has finished for PR 6755 at commit
|
| return false; | ||
| } | ||
| for (int i = 0; i < n; i ++) { | ||
| if (isNullAt(i) != row.isNullAt(i) || !isNullAt(i) && !get(i).equals(row.get(i))) { |
There was a problem hiding this comment.
Will that cause NPE for !get(i).equals(row.get(i))
There was a problem hiding this comment.
Sorry, ignore the above comment. But it's better to add a bracket for !isNullAt(i) && !get(i).equals(row.get(i))
|
Test build #34664 has finished for PR 6755 at commit
|
| (c1, c3) => s"$c1 $symbol $c3" | ||
| if (ctx.isPrimitiveType(left.dataType)) { | ||
| // faster version | ||
| defineCodeGen(ctx, ev, { |
There was a problem hiding this comment.
can we just do
defineCodeGen(ctx, ev, (c1, c2) => s"$c1 $symbol $c2")
in one line for everything here?
|
Test build #34699 has finished for PR 6755 at commit
|
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This PR fix a few small issues about codgen: 1. cast decimal to boolean 2. do not inline literal with null 3. improve SpecificRow.equals() 4. test expressions with optimized express 5. fix compare with BinaryType cc rxin chenghao-intel Author: Davies Liu <davies@databricks.com> Closes apache#6755 from davies/fix_codegen and squashes the following commits: ef27343 [Davies Liu] address comments 6617ea6 [Davies Liu] fix scala tyle 70b7dda [Davies Liu] improve codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix a few small issues about codgen:
cc @rxin @chenghao-intel