New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-6855] [SPARKR] Set R includes to get the right collate order. #5462

Closed

shivaram wants to merge 1 commit into apache:master from shivaram:collate-order

Contributor

shivaram commented Apr 10, 2015

This prevents tools like devtools::document creating invalid collate orders


          Set R includes to get the right collate order.

f3db562

This prevents tools like devtools::document creating invalid
collate orders

Contributor Author

shivaram commented Apr 10, 2015

cc @cafreeman @davies

cafreeman commented Apr 10, 2015

You may want to pull in the schema changes from earlier today since SQLtypes.R was replaced with schema.R

SparkQA commented Apr 11, 2015

Test build #30058 has finished for PR 5462 at commit f3db562.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Contributor Author

shivaram commented Apr 11, 2015

@cafreeman We will pull that change in #5436 and @davies will take care of merging it correctly.

Contributor

davies commented Apr 16, 2015

LGTM.

@shivaram Could you merge this today? then I can rebase #5436

SparkQA commented Apr 16, 2015

Test build #684 has finished for PR 5462 at commit f3db562.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Contributor Author

shivaram commented Apr 16, 2015

Thanks @davies - I don't think the error has anything to do with this PR, but let me retest it anyways to be safe

Jenkins, retest this please

SparkQA commented Apr 16, 2015

Test build #686 has finished for PR 5462 at commit f3db562.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

asfgit closed this in

55f553a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet