[MINOR][DOCS] Clarify spark.remote and spark.master in pyspark-connect and pyspark-client at install.rst #50054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueshin
approved these changes
Feb 24, 2025
zhengruifeng
approved these changes
Feb 24, 2025
| Note that ``pyspark`` command will use ``--master`` option for Spark Connect remote URL instead of ``--remote`` option. | ||
|
|
||
| See also `Quickstart: Spark Connect <quickstart_connect.html>`_ for how to use it. | ||
| This package supports both ``spark.master`` (``--master``) with a locally running Spark Connect server, and ``spark.remote`` (``--remote``) including ``local*`` as well as connection URIs such as ``sc://localhost``. See also `Quickstart: Spark Connect <quickstart_connect.html>`_ for how to use it. |
There was a problem hiding this comment.
Does local* mean local[K,F] syntax in this line, @HyukjinKwon ? If then, it looks a little confusing to me.
There was a problem hiding this comment.
Actually I also meant local-cluster too :-)..
There was a problem hiding this comment.
let me fix a little bit more
dongjoon-hyun
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
+1, LGTM for the other parts. Only one minor comment about clarification.
Thank you, @HyukjinKwon .
|
Merged to master and branch-4.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 24, 2025
…t and pyspark-client at install.rst ### What changes were proposed in this pull request? This PR fixes the installation page for PySpark to clarify spark.remote and spark.master in pyspark-connect and pyspark-client at install.rst ### Why are the changes needed? To clarify spark.remote and spark.master in pyspark-connect and pyspark-client ### Does this PR introduce _any_ user-facing change? No. doc-only change. ### How was this patch tested? CI build in this PR ### Was this patch authored or co-authored using generative AI tooling? No. Closes #50054 from HyukjinKwon/minor-doc-change1. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit c6097c7) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the installation page for PySpark to clarify spark.remote and spark.master in pyspark-connect and pyspark-client at install.rst
Why are the changes needed?
To clarify spark.remote and spark.master in pyspark-connect and pyspark-client
Does this PR introduce any user-facing change?
No. doc-only change.
How was this patch tested?
CI build in this PR
Was this patch authored or co-authored using generative AI tooling?
No.