[SPARK-51142][ML][CONNECT] ML protobufs clean up #49862
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
commented
Feb 10, 2025
| TRANSFORMER = 2; | ||
| EVALUATOR = 3; | ||
| MODEL = 4; | ||
| OPERATOR_TYPE_UNSPECIFIED = 0; |
There was a problem hiding this comment.
rename to follow the protobuf style guide
Prefix every value with the enum name (converted to UPPER_SNAKE_CASE)
|
cc @grundprinzip and @wbo4958 |
|
The failed protobuf breaking change test is expected, we will merge this also in 4.0 |
grundprinzip
approved these changes
Feb 10, 2025
43b4bcb to
7feab04
Compare
HyukjinKwon
approved these changes
Feb 11, 2025
|
I am going to merge this into 4.0, otherwise the protobuf compatibility between 4.0 and 4.1 will be broken |
zhengruifeng
added a commit
that referenced
this pull request
Feb 11, 2025
### What changes were proposed in this pull request? ML protobufs clean up ### Why are the changes needed? to follow the guide https://github.com/apache/spark/blob/ece14704cc083f17689d2e0b9ab8e31cf71a7a2d/sql/connect/docs/adding-proto-messages.md ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests ### Was this patch authored or co-authored using generative AI tooling? no Closes #49862 from zhengruifeng/ml_connect_protos. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org> (cherry picked from commit 6a71f76) Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
|
merged to master/4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ML protobufs clean up
Why are the changes needed?
to follow the guide https://github.com/apache/spark/blob/ece14704cc083f17689d2e0b9ab8e31cf71a7a2d/sql/connect/docs/adding-proto-messages.md
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests
Was this patch authored or co-authored using generative AI tooling?
no