[SPARK-51048][CORE] Support stop java spark context with exit code #49746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dongjoon-hyun could you please take a look, thank you ! |
HyukjinKwon
reviewed
Feb 3, 2025
| @@ -552,6 +552,11 @@ class JavaSparkContext(val sc: SparkContext) extends Closeable { | |||
| sc.stop() | |||
| } | |||
|
|
|||
| /** Shut down the SparkContext with exit code. */ | |||
There was a problem hiding this comment.
done, please re-review
There was a problem hiding this comment.
You can copy and paste from Scala's one ..
There was a problem hiding this comment.
done @HyukjinKwon , please re-review. Test case failing seems to be unrelated
HyukjinKwon
approved these changes
Feb 5, 2025
|
Hi @HyukjinKwon Kindly merge the PR if all looks good. |
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Considering there is support to stop spark context with required exit code, This PR aims to use the same to add it to java spark context as well.
Why are the changes needed?
Currently to use
stop(exitCode)method for JavaSparkContext, user has to calljavaSparkContextsparkContext.stop(exitCode).Post this PR user can directly do
javaSparkContextsparkContext.stop(exitCode)to invoke same.Does this PR introduce any user-facing change?
No, it introduces an extra method in JavaSparkContext class
How was this patch tested?
This was tested in internal/production k8 cluster
Was this patch authored or co-authored using generative AI tooling?
No