Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-50525][SQL][TESTS][FOLLOWUP] Fix DataFrameSuite.repartition by MapType test assumption #49457

Closed
wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 12, 2025

What changes were proposed in this pull request?

This is a follow-up to recover the NON-ANSI mode CI failure by adding a test assumption clearly.

Why are the changes needed?

BEFORE

$ SPARK_ANSI_SQL_MODE=false build/sbt "sql/testOnly *.DataFrameSuite -- -z MapType"
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] 	org.apache.spark.sql.DataFrameSuite

AFTER

$ SPARK_ANSI_SQL_MODE=false build/sbt "sql/testOnly *.DataFrameSuite -- -z MapType"
[info] All tests passed.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually test with SPARK_ANSI_SQL_MODE=false.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun
Copy link
Member Author

cc @ostronaut and @cloud-fan

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-50525][SQL][TESTS][FOLLOWUP] Fix DataFrameSuite.repartition by MapType to be clear test assumption [SPARK-50525][SQL][TESTS][FOLLOWUP] Fix DataFrameSuite.repartition by MapType test assumption Jan 12, 2025
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@dongjoon-hyun
Copy link
Member Author

Thank you, @cloud-fan . Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-50525 branch January 13, 2025 02:29
@ostronaut
Copy link
Contributor

Thank you @dongjoon-hyun for fixing it! I was not aware that SPARK_ANSI_SQL_MODE might cause some issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants