[SPARK-50064][PYTHON][TESTS] Make pysaprk-ml-connect tests passing without optional dependencies #48587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @zhengruifeng This should fix all in https://github.com/apache/spark/actions/runs/11447673972 |
zhengruifeng
approved these changes
Oct 22, 2024
|
Merged to master. |
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Oct 22, 2024
…thout optional dependencies ### What changes were proposed in this pull request? This PR proposes to make pysaprk-ml-connect tests passing without optional dependencies ### Why are the changes needed? To make the tests passing without optional dependencies. See https://github.com/apache/spark/actions/runs/11447673972/job/31849621508 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran it locally ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#48587 from HyukjinKwon/SPARK-50064. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
There was a problem hiding this comment.
Nice. Thank you, @HyukjinKwon and @zhengruifeng .
Could you handle python/pyspark/ml/tests/connect/test_legacy_mode_tuning.py too?
Starting test(python3.13): pyspark.ml.tests.connect.test_legacy_mode_tuning (temp output: /__w/spark/spark/python/target/0860e4ec-da41-44ae-94d0-7e9686e40223/python3.13__pyspark.ml.tests.connect.test_legacy_mode_tuning__p5btkvov.log)
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/__w/spark/spark/python/pyspark/ml/tests/connect/test_legacy_mode_tuning.py", line 62, in <module>
class InducedErrorModel(Model, HasInducedError):
^^^^^
NameError: name 'Model' is not defined
|
fixing it now ... |
HyukjinKwon
added a commit
that referenced
this pull request
Oct 23, 2024
… without optional dependencies ### What changes were proposed in this pull request? This PR is a followup of #48587 that proposes to make pysaprk-ml tests passing without optional dependencies ### Why are the changes needed? To make the tests passing without optional dependencies. See https://github.com/apache/spark/actions/runs/11447673972/job/31849621508 ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually ran it locally ### Was this patch authored or co-authored using generative AI tooling? No. Closes #48606 from HyukjinKwon/SPARK-50064-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make pysaprk-ml-connect tests passing without optional dependencies
Why are the changes needed?
To make the tests passing without optional dependencies. See https://github.com/apache/spark/actions/runs/11447673972/job/31849621508
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually ran it locally
Was this patch authored or co-authored using generative AI tooling?
No.