[SPARK-49879][CORE] Move TransportCipherUtil to a separate file to eliminate Java compilation warnings
#48352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Oct 4, 2024
| /* | ||
| * This method is used for testing to verify key derivation. | ||
| */ | ||
| @VisibleForTesting |
There was a problem hiding this comment.
Shall we use 2-space indentation, @LuciferYang ? Although it follows the original source, we had better change the style according to the Apache Spark community policy.
There was a problem hiding this comment.
3b10ead reformatted TransportCipherUtil.java
dongjoon-hyun
approved these changes
Oct 4, 2024
|
Thank you, @LuciferYang . |
|
Merged to master. Thank you, @LuciferYang and @MaxGekk . |
|
Thanks @dongjoon-hyun and @MaxGekk |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…eliminate Java compilation warnings ### What changes were proposed in this pull request? Run `build/mvn clean install -pl common/network-common`, we can see the following compilation warnings: ``` [WARNING] [Warn] /Users/yangjie01/SourceCode/git/spark-maven/common/network-common/src/main/java/org/apache/spark/network/crypto/CtrTransportCipher.java:73:11: auxiliary class TransportCipherUtil in /Users/yangjie01/SourceCode/git/spark-maven/common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java should not be accessed from outside its own source file [WARNING] [Warn] /Users/yangjie01/SourceCode/git/spark-maven/common/network-common/src/main/java/org/apache/spark/network/crypto/GcmTransportCipher.java:63:15: auxiliary class TransportCipherUtil in /Users/yangjie01/SourceCode/git/spark-maven/common/network-common/src/main/java/org/apache/spark/network/crypto/TransportCipher.java should not be accessed from outside its own source file ``` So this pr moves `TransportCipherUtil` to a separate file to eliminate the aforementioned Java compilation warnings. ### Why are the changes needed? Fix compilation warnings. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass GitHub Actions - locally run `build/mvn clean install -pl common/network-common`, no longer have the aforementioned compilation warnings. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48352 from LuciferYang/Move-TransportCipherUtil. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Run
build/mvn clean install -pl common/network-common, we can see the following compilation warnings:So this pr moves
TransportCipherUtilto a separate file to eliminate the aforementioned Java compilation warnings.Why are the changes needed?
Fix compilation warnings.
Does this PR introduce any user-facing change?
No
How was this patch tested?
build/mvn clean install -pl common/network-common, no longer have the aforementioned compilation warnings.Was this patch authored or co-authored using generative AI tooling?
No