[SPARK-49866][SQL] Improve the error message for describe table with partition columns #48338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
requested changes
Oct 3, 2024
There was a problem hiding this comment.
In this ticket https://databricks.atlassian.net/browse/ES-1122552 we
@mihailoale-db Please, don't refer to internal Databricks tickets.
MaxGekk
requested changes
Oct 3, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeTableExec.scala
Outdated
Show resolved
Hide resolved
MaxGekk
requested changes
Oct 4, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeTableExec.scala
Outdated
Show resolved
Hide resolved
Should we remove this comment? |
Yes, please, do that. |
MaxGekk
requested changes
Oct 4, 2024
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeTableExec.scala
Outdated
Show resolved
Hide resolved
|
@MaxGekk All the CIs passed except the Kubernetes one. |
|
I believe the test failure Run / Run Spark on Kubernetes Integration test is not related to the changes. +1, LGTM. Merging to master. |
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
…partition columns ### What changes were proposed in this pull request? Provide more user facing error when partition column name can't be found in the table schema. ### Why are the changes needed? There's an issue where partition column sometimes doesn't match any from the table schema. When that happens we throw an assertion error which is not user friendly. Because of that we introduced new `QueryExecutionError` in order to make it more user facing. ### Does this PR introduce _any_ user-facing change? Yes, users will get more user friendly error message. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#48338 from mihailoale-db/mihailoale-db/fixdescribepartitioningmessage. Authored-by: Mihailo Aleksic <mihailo.aleksic@databricks.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Provide more user facing error when partition column name can't be found in the table schema.
Why are the changes needed?
There's an issue where partition column sometimes doesn't match any from the table schema. When that happens we throw an assertion error which is not user friendly. Because of that we introduced new
QueryExecutionErrorin order to make it more user facing.Does this PR introduce any user-facing change?
Yes, users will get more user friendly error message.
Was this patch authored or co-authored using generative AI tooling?
No