Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49049][DOCS] Document MasterPage custom title conf and REST API server-side env variable replacements #47523

Closed
wants to merge 3 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jul 29, 2024

What changes were proposed in this pull request?

This PR aims to document the following three recent improvements.

Why are the changes needed?

To provide an updated documentation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs and check the HTML manually.

Screenshot 2024-07-29 at 14 10 40 Screenshot 2024-07-29 at 13 52 20 Screenshot 2024-07-29 at 13 52 29

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the DOCS label Jul 29, 2024
@dongjoon-hyun
Copy link
Member Author

cc @yaooqinn and @viirya

The documentation was also requested before by @yaooqinn in the previous PR.

@dongjoon-hyun
Copy link
Member Author

Thank you, @viirya !

@dongjoon-hyun
Copy link
Member Author

Thank you always, @viirya .

Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
@dongjoon-hyun
Copy link
Member Author

Thank you for the clarification! I merged it.

@viirya
Copy link
Member

viirya commented Jul 29, 2024

Thank you @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn .
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-49049 branch July 30, 2024 03:54
fusheng9399 pushed a commit to fusheng9399/spark that referenced this pull request Aug 6, 2024
…I server-side env variable replacements

### What changes were proposed in this pull request?

This PR aims to document the following three recent improvements.
- apache#47491
- apache#47509
- apache#47511

### Why are the changes needed?

To provide an updated documentation.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and check the HTML manually.

<img width="926" alt="Screenshot 2024-07-29 at 14 10 40" src="https://github.com/user-attachments/assets/6c904ec0-0ece-432a-8e41-aeb88f7baab8">

<img width="932" alt="Screenshot 2024-07-29 at 13 52 20" src="https://github.com/user-attachments/assets/ca3afe9a-dcfe-4258-b455-9ff4781cb4e5">

<img width="940" alt="Screenshot 2024-07-29 at 13 52 29" src="https://github.com/user-attachments/assets/ad9635d4-c66f-4320-8b93-005443d4df2e">

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47523 from dongjoon-hyun/SPARK-49049.

Lead-authored-by: Dongjoon Hyun <dhyun@apple.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Aug 7, 2024
…I server-side env variable replacements

This PR aims to document the following three recent improvements.
- apache#47491
- apache#47509
- apache#47511

To provide an updated documentation.

No.

Pass the CIs and check the HTML manually.

<img width="926" alt="Screenshot 2024-07-29 at 14 10 40" src="https://github.com/user-attachments/assets/6c904ec0-0ece-432a-8e41-aeb88f7baab8">

<img width="932" alt="Screenshot 2024-07-29 at 13 52 20" src="https://github.com/user-attachments/assets/ca3afe9a-dcfe-4258-b455-9ff4781cb4e5">

<img width="940" alt="Screenshot 2024-07-29 at 13 52 29" src="https://github.com/user-attachments/assets/ad9635d4-c66f-4320-8b93-005443d4df2e">

No.

Closes apache#47523 from dongjoon-hyun/SPARK-49049.

Lead-authored-by: Dongjoon Hyun <dhyun@apple.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
attilapiros pushed a commit to attilapiros/spark that referenced this pull request Oct 4, 2024
…I server-side env variable replacements

### What changes were proposed in this pull request?

This PR aims to document the following three recent improvements.
- apache#47491
- apache#47509
- apache#47511

### Why are the changes needed?

To provide an updated documentation.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and check the HTML manually.

<img width="926" alt="Screenshot 2024-07-29 at 14 10 40" src="https://github.com/user-attachments/assets/6c904ec0-0ece-432a-8e41-aeb88f7baab8">

<img width="932" alt="Screenshot 2024-07-29 at 13 52 20" src="https://github.com/user-attachments/assets/ca3afe9a-dcfe-4258-b455-9ff4781cb4e5">

<img width="940" alt="Screenshot 2024-07-29 at 13 52 29" src="https://github.com/user-attachments/assets/ad9635d4-c66f-4320-8b93-005443d4df2e">

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47523 from dongjoon-hyun/SPARK-49049.

Lead-authored-by: Dongjoon Hyun <dhyun@apple.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
himadripal pushed a commit to himadripal/spark that referenced this pull request Oct 19, 2024
…I server-side env variable replacements

### What changes were proposed in this pull request?

This PR aims to document the following three recent improvements.
- apache#47491
- apache#47509
- apache#47511

### Why are the changes needed?

To provide an updated documentation.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs and check the HTML manually.

<img width="926" alt="Screenshot 2024-07-29 at 14 10 40" src="https://github.com/user-attachments/assets/6c904ec0-0ece-432a-8e41-aeb88f7baab8">

<img width="932" alt="Screenshot 2024-07-29 at 13 52 20" src="https://github.com/user-attachments/assets/ca3afe9a-dcfe-4258-b455-9ff4781cb4e5">

<img width="940" alt="Screenshot 2024-07-29 at 13 52 29" src="https://github.com/user-attachments/assets/ad9635d4-c66f-4320-8b93-005443d4df2e">

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#47523 from dongjoon-hyun/SPARK-49049.

Lead-authored-by: Dongjoon Hyun <dhyun@apple.com>
Co-authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants