[SPARK-48307][SQL][FOLLOWUP] Allow outer references in un-referenced CTE relations #46869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @viirya |
viirya
approved these changes
Jun 4, 2024
HyukjinKwon
approved these changes
Jun 5, 2024
c45fc42 to
cbb4c7e
Compare
|
thanks for the review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #46617 . Subquery expression has a bunch of correlation checks which need to match certain plan shapes. We broke this by leaving
WithCTEin the plan for un-referenced CTE relations. This PR fixes the issue by skipping CTE plan nodes in correlated subquery expression checks.Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no bug is not released yet.
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no