Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-47202][PYTHON] Fix typo breaking datetimes with tzinfo #45301

Closed
wants to merge 2 commits into from
Closed

[SPARK-47202][PYTHON] Fix typo breaking datetimes with tzinfo #45301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cde6f5
done
arzavj Feb 28, 2024
1b22ba6
ci
arzavj Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyspark/sql/pandas/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ def convert_struct(value: Any) -> Any:

def convert_timestamp(value: Any) -> Any:
if isinstance(value, datetime.datetime) and value.tzinfo is not None:
ts = pd.Timstamp(value)
ts = pd.Timestamp(value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine as is because it's pretty obvious but would be good to have a test at python/pyspark/sql/tests/test_arrow.py.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the above comment about adding a test coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I considered adding a test for this but really what we need here is a linter in CI to catch such typos

else:
ts = pd.Timestamp(value).tz_localize(timezone)
return ts.to_pydatetime()
Expand Down