[SPARK-46791][SQL] Support Java Set in JavaTypeInference #44828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jan 22, 2024
yaooqinn
approved these changes
Jan 22, 2024
|
The failures are irrelevant ones. |
|
Thank you @dongjoon-hyun @yaooqinn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch adds the support of Java
Setas bean field inJavaTypeInference.Why are the changes needed?
Scala
Set(scala.collection.Set) is supported inScalaReflectionso users can encode ScalaSetin Dataset. But JavaSetis not supported in bean encoder (i.e.,JavaTypeInference). This feature inconsistency makes Java users cannot useSetlike Scala users do.Does this PR introduce any user-facing change?
Yes. Java
Setis supported to be part of Java bean when encoding with bean encoder.How was this patch tested?
Added tests.
Was this patch authored or co-authored using generative AI tooling?
No