[SPARK-40559][PYTHON][DOCS][FOLLOW-UP] Fix the docstring and document both applyInArrows #44139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
approved these changes
Dec 4, 2023
e4b7d87 to
7633465
Compare
HyukjinKwon
commented
Dec 4, 2023
| @@ -652,9 +651,9 @@ def applyInArrow( | |||
| Parameters | |||
| ---------- | |||
| func : function | |||
| a Python native function that takes two `pyarrow.Table`s, and | |||
| a Python native function that takes two `pyarrow.Table`\\s, and | |||
There was a problem hiding this comment.
Otherwise, it fails as below:
/__w/spark/spark/python/pyspark/sql/pandas/group_ops.py:docstring of pyspark.sql.pandas.group_ops.PandasCogroupedOps.applyInArrow:73:Inline interpreted text or phrase reference start-string without end-string.
This is consistent with applyInPandas.
|
Merged to master~ |
asl3
pushed a commit
to asl3/spark
that referenced
this pull request
Dec 5, 2023
… both applyInArrows ### What changes were proposed in this pull request? This PR is a followup of apache#38624 that documents both applyInArrows with a docstring fix. ### Why are the changes needed? For end users to refer the API documentation. ### Does this PR introduce _any_ user-facing change? No, the main change has not been released out yet. ### How was this patch tested? Existing CI, and documentation build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44139 from HyukjinKwon/SPARK-40559-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dbatomic
pushed a commit
to dbatomic/spark
that referenced
this pull request
Dec 11, 2023
… both applyInArrows ### What changes were proposed in this pull request? This PR is a followup of apache#38624 that documents both applyInArrows with a docstring fix. ### Why are the changes needed? For end users to refer the API documentation. ### Does this PR introduce _any_ user-facing change? No, the main change has not been released out yet. ### How was this patch tested? Existing CI, and documentation build. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44139 from HyukjinKwon/SPARK-40559-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #38624 that documents both applyInArrows with a docstring fix.
Why are the changes needed?
For end users to refer the API documentation.
Does this PR introduce any user-facing change?
No, the main change has not been released out yet.
How was this patch tested?
Existing CI, and documentation build.
Was this patch authored or co-authored using generative AI tooling?
No.