Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-45318][SHELL][TESTS] Merge test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite #43104

Closed
wants to merge 1 commit into from

Conversation

LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Sep 25, 2023

What changes were proposed in this pull request?

This pr aims to merge test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite to reduce duplicate code.

Why are the changes needed?

#28545 split the relevant test cases from SingletonReplSuite/ReplSuite into SingletonRepl2Suite/Repl2Suite, distinguishing different test versions of Scala 2.12 and Scala 2.13.

Currently, Spark 4.0 no longer supports Scala 2.12, so they can be merged back into the original files to reduce duplicate code.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

Was this patch authored or co-authored using generative AI tooling?

No

@LuciferYang LuciferYang changed the title [SPARK-45318][TESTS] Merge the test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite [SPARK-45318][TESTS] Merge test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite Sep 25, 2023
@LuciferYang LuciferYang changed the title [SPARK-45318][TESTS] Merge test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite [SPARK-45318][SHELL][TESTS] Merge test cases from SingletonRepl2Suite/Repl2Suite back into SingletonReplSuite/ReplSuite Sep 25, 2023
@LuciferYang
Copy link
Contributor Author

cc @HyukjinKwon @srowen @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 4.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants