Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-5135][SQL] Add support for describe [extended] table to DDL in SQLContext #4127

Closed
wants to merge 5 commits into from
Closed

[SPARK-5135][SQL] Add support for describe [extended] table to DDL in SQLContext #4127

wants to merge 5 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Jan 21, 2015

This brings #3935 up to date and fixes style violations.

OopsOutOfMemory and others added 5 commits January 16, 2015 18:45
@OopsOutOfMemory
patch
5b7ae19
@OopsOutOfMemory
refine imports
d1689e2
@rxin
Merge pull request apache#3935 from OopsOutOfMemory/describe
2c4fc5a 
[SPARK-5135][SQL] Add support for describe [extended] table to DDL in SQLContext

Conflicts:
	sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala
@rxin
Patch up.
526c3b0
@rxin
More style fixes.
b1a0f6a
@rxin rxin mentioned this pull request Jan 21, 2015
Closed
@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25859 has started for PR 4127 at commit b1a0f6a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25859 has finished for PR 4127 at commit b1a0f6a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25859/
Test PASSed.

marmbrus
marmbrus reviewed Jan 21, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala
@@ -300,6 +301,8 @@ case object StringType extends NativeType with PrimitiveType {
* The default size of a value of the StringType is 4096 bytes.
*/
override def defaultSize: Int = 4096

override def toSimpleString = "string"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this what typeName is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here to replace string with TypeName is ok.
But not all typeName equals simple string.
i.e
LongType, the typeName of it is long but not bigint... etc...

def typeName: String = this.getClass.getSimpleName.stripSuffix("$").dropRight(4).toLowerCase

@OopsOutOfMemory
Copy link
Contributor

Hi, @rxin
I created a new PR #4227 to rewrite this part and bring everything up-to-date, would you please review it?

@OopsOutOfMemory OopsOutOfMemory mentioned this pull request Jan 27, 2015
Closed
@rxin
Copy link
Contributor Author

rxin commented Jan 27, 2015

Thanks. Do you mind closing this one?

@OopsOutOfMemory
Copy link
Contributor

ok, please close this one : )

@rxin
Copy link
Contributor Author

rxin commented Jan 27, 2015

I don't have permission to do it. Can you click the close button?

@OopsOutOfMemory
Copy link
Contributor

I don't have permission, too. I only have comment permission here.
what's going wrong?

@rxin
Copy link
Contributor Author

rxin commented Jan 27, 2015

Ah never mind this is my own pull request. Closing it.

@rxin rxin closed this Jan 27, 2015
asfgit pushed a commit that referenced this pull request Feb 5, 2015
@OopsOutOfMemory @rxin
[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext
55cebcf 
Hi, rxin marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

Author: OopsOutOfMemory <victorshengli@126.com>

Closes #4227 from OopsOutOfMemory/describe and squashes the following commits:

053826f [OopsOutOfMemory] describe

(cherry picked from commit 4d8d070)
Signed-off-by: Reynold Xin <rxin@databricks.com>
asfgit pushed a commit that referenced this pull request Feb 5, 2015
@OopsOutOfMemory @rxin
[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext
4d8d070 
Hi, rxin marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

Author: OopsOutOfMemory <victorshengli@126.com>

Closes #4227 from OopsOutOfMemory/describe and squashes the following commits:

053826f [OopsOutOfMemory] describe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rxin @SparkQA @AmplabJenkins @OopsOutOfMemory @marmbrus