-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-5038] Add explicit return type for implicit functions. #3860
Conversation
This is a follow up PR for rest of Spark (outside Spark SQL). The original PR for Spark SQL can be found at apache#3859
Test build #24967 has started for PR 3860 at commit
|
Test build #24967 has finished for PR 3860 at commit
|
Test FAILed. |
Jenkins, retest this please. |
Test build #24974 has started for PR 3860 at commit
|
It looks like the |
Test build #24974 has finished for PR 3860 at commit
|
Test PASSed. |
LGTM. I guess the only way that this could introduce problems would be if you changed the explicit type to be wider than the implicit type that was being inferred before, but it doesn't look like that's the case here. |
Thanks. Merging in master. |
As we learned in #3580, not explicitly typing implicit functions can lead to compiler bugs and potentially unexpected runtime behavior.
This is a follow up PR for rest of Spark (outside Spark SQL). The original PR for Spark SQL can be found at #3859