Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4298][Core] - The spark-submit cannot read Main-Class from Manifest. #3561

Closed
wants to merge 6 commits into from
Closed

[SPARK-4298][Core] - The spark-submit cannot read Main-Class from Manifest. #3561

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8da7cbf
fixes SPARK-4298
Nov 27, 2014
a043039
updated to split the uri and jar vals
Dec 2, 2014
8d20936
updated to reset the error message back to the default
Dec 2, 2014
c6dad68
Set case statement to support multiple jar URI's and enabled the 'fil…
Dec 11, 2014
14daa20
pushed mainClass assignment into match statement, removed spurious sp…
Dec 11, 2014
5e0fce1
Use string interpolation for error messages, moved comment line from …
Dec 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

package org.apache.spark.deploy

import java.net.URI
import java.util.jar.JarFile

import scala.collection.mutable.{ArrayBuffer, HashMap}
Expand Down Expand Up @@ -123,14 +124,23 @@ private[spark] class SparkSubmitArguments(args: Seq[String], env: Map[String, St

// Try to set main class from JAR if no --class argument is given
if (mainClass == null && !isPython && primaryResource != null) {
try {
val jar = new JarFile(primaryResource)
// Note that this might still return null if no main-class is set; we catch that later
mainClass = jar.getManifest.getMainAttributes.getValue("Main-Class")
} catch {
case e: Exception =>
SparkSubmit.printErrorAndExit("Cannot load main class from JAR: " + primaryResource)
return
val uri = new URI(primaryResource)
val uriScheme = uri.getScheme()

uriScheme match {
case "file" =>
try {
val jar = new JarFile(uri.getPath)
// Note that this might still return null if no main-class is set; we catch that later
mainClass = jar.getManifest.getMainAttributes.getValue("Main-Class")
} catch {
case e: Exception =>
SparkSubmit.printErrorAndExit(s"Cannot load main class from JAR $primaryResource")
}
case _ =>
SparkSubmit.printErrorAndExit(
s"Cannot load main class from JAR $primaryResource with URI $uriScheme. " +
"Please specify a class through --class.")
}
}

Expand Down