Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4536][SQL] Add sqrt and abs to Spark SQL DSL #3401

Closed
wants to merge 4 commits into from
Closed

[SPARK-4536][SQL] Add sqrt and abs to Spark SQL DSL #3401

wants to merge 4 commits into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Nov 21, 2014

Spark SQL has embeded sqrt and abs but DSL doesn't support those functions.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23720 has started for PR 3401 at commit 0396f89.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23720 has finished for PR 3401 at commit 0396f89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23720/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23962 has started for PR 3401 at commit 1b88e2e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 1, 2014

Test build #23962 has finished for PR 3401 at commit 1b88e2e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • trait ConnectionFactory extends Serializable

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23962/
Test PASSed.

marmbrus
marmbrus reviewed Dec 2, 2014
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/DslQuerySuite.scala
)

checkAnswer(
testData.select(upper(Literal(null, NullType))),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This can just be Literal(null)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've modified.

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24015 has started for PR 3401 at commit bc5f4cb.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24015 has finished for PR 3401 at commit bc5f4cb.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24015/
Test FAILed.

@sarutak sarutak force-pushed the dsl-missing-operator branch from bc5f4cb to 07700cf Compare December 2, 2014 02:18
@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24016 has started for PR 3401 at commit 07700cf.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 2, 2014

Test build #24016 has finished for PR 3401 at commit 07700cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24016/
Test PASSed.

asfgit pushed a commit that referenced this pull request Dec 2, 2014
@sarutak @marmbrus
[SPARK-4536][SQL] Add sqrt and abs to Spark SQL DSL
1850d90 
Spark SQL has embeded sqrt and abs but DSL doesn't support those functions.

Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>

Closes #3401 from sarutak/dsl-missing-operator and squashes the following commits:

07700cf [Kousuke Saruta] Modified Literal(null, NullType) to Literal(null) in DslQuerySuite
8f366f8 [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into dsl-missing-operator
1b88e2e [Kousuke Saruta] Merge branch 'master' of git://git.apache.org/spark into dsl-missing-operator
0396f89 [Kousuke Saruta] Added sqrt and abs to Spark SQL DSL

(cherry picked from commit e75e04f)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@asfgit asfgit closed this in e75e04f Dec 2, 2014
@marmbrus
Copy link
Contributor

marmbrus commented Dec 2, 2014

Thanks! Merged to master and 1.2.

@sarutak sarutak deleted the dsl-missing-operator branch April 11, 2015 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarutak @SparkQA @AmplabJenkins @marmbrus