Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-4467] Partial fix for fetch failure in sort-based shuffle (1.1) #3330

Closed
wants to merge 1 commit into from
Closed

[SPARK-4467] Partial fix for fetch failure in sort-based shuffle (1.1) #3330

wants to merge 1 commit into from

Conversation

andrewor14
Copy link
Contributor

This is the 1.1 version of #3302. There has been some refactoring in master so we can't cherry-pick that PR.

@SparkQA
Copy link

SparkQA commented Nov 18, 2014

QA tests have started for PR 3330 at commit 486fc49.

  • This patch merges cleanly.

@mateiz
Copy link
Contributor

mateiz commented Nov 18, 2014

LGTM

@SparkQA
Copy link

SparkQA commented Nov 18, 2014

QA tests have finished for PR 3330 at commit 486fc49.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23517/
Test PASSed.

@andrewor14 andrewor14 changed the title [SPARK-4452] Partial fix for fetch failure in sort-based shuffle (1.1) [SPARK-4467] Partial fix for fetch failure in sort-based shuffle (1.1) Nov 18, 2014
@andrewor14
Copy link
Contributor Author

Alright I'm merging this into 1.1 thanks.

asfgit pushed a commit that referenced this pull request Nov 18, 2014
[SPARK-4467] Partial fix for fetch failure in sort-based shuffle (1.1)
aa9ebda 
This is the 1.1 version of #3302. There has been some refactoring in master so we can't cherry-pick that PR.

Author: Andrew Or <andrew@databricks.com>

Closes #3330 from andrewor14/sort-fetch-fail and squashes the following commits:

486fc49 [Andrew Or] Reset `elementsRead`
@pwendell
Copy link
Contributor

@andrewor14 you'll need to close this PR manually yourself

@tsdeng
Copy link
Contributor

tsdeng commented Nov 18, 2014

made more changes to #3302

may need to rebase

@andrewor14
Copy link
Contributor Author

Yeah. Weird that github doesn't even have a "delete branch" button for these PRs.

@andrewor14 andrewor14 closed this Nov 18, 2014
@andrewor14 andrewor14 deleted the sort-fetch-fail branch November 18, 2014 06:49
@andrewor14 andrewor14 mentioned this pull request Nov 19, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewor14 @SparkQA @mateiz @AmplabJenkins @pwendell @tsdeng