[SPARK-34152][SQL][FOLLOW-UP] Global temp view's identifier should be correctly stored #31783
Conversation
|
cc @cloud-fan TIA! |
| @@ -909,4 +910,21 @@ abstract class SQLViewSuite extends QueryTest with SQLTestUtils { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| test("SPARK-34152: global temp view's identifier should be correctly stored") { | |||
There was a problem hiding this comment.
can we move it to the new GlobalTempViewTestSuite? we should slowly move all the view tests to SQLViewTestSuite framework.
There was a problem hiding this comment.
+1 for @cloud-fan 's suggestion.
|
|
||
| test("SPARK-34152: view's identifier should be correctly stored") { | ||
| Seq(true, false).foreach { storeAnalyzed => | ||
| withSQLConf(STORE_ANALYZED_PLAN_FOR_VIEW.key -> storeAnalyzed.toString) { |
There was a problem hiding this comment.
This has no effect for permanent view, and please let me know if this is not desirable. I can introduce isTempView for each suite and only apply this if the suite is for a local or global temp view.
There was a problem hiding this comment.
it's ok to have a little waste in the test.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #135900 has finished for PR 31783 at commit
|
|
thanks, merging to master! |
What changes were proposed in this pull request?
This PR proposed to fix a bug introduced in #31273 (https://github.com/apache/spark/pull/31273/files#r589494855).
Why are the changes needed?
This fixes a bug where global temp view's database name was not passed correctly.
Does this PR introduce any user-facing change?
Yes, now the global temp view's database is correctly stored.
How was this patch tested?
Added a new test that catches the bug.