-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33156][INFRA] Upgrade GithubAction image from 18.04 to 20.04 #30050
Conversation
Test build #129812 has finished for PR 30050 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like ubuntu-20.04
is a preview one and that's why ubuntu-latest
doesn't point this out (I read actions/runner-images#1430 and https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources).
Should we just maybe leave it as is so GitHub Actions will updates it in their side? In this way, we could avoid updating this version later when another Ubuntu comes out.
The reason why they are still there officially is that they couldn't verify that how many plugins (or actions) in their market place fail to support it. However, it's not true for us. I verified that And, |
Test FAILed. |
@@ -17,7 +17,7 @@ jobs: | |||
# Build: build Spark and run the tests for specified modules. | |||
build: | |||
name: "Build modules: ${{ matrix.modules }} ${{ matrix.comment }} (JDK ${{ matrix.java }}, ${{ matrix.hadoop }}, ${{ matrix.hive }})" | |||
runs-on: ubuntu-latest | |||
runs-on: ubuntu-20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: how about leaving comments about the next LTS of ubuntu-20.04 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO latest
was a bit ambiguous, so the new one (ubuntu-20.04
) can make it easier to understand in which environment we run tests. Thanks, @dongjoon-hyun !
Seems fine to me |
Thank you, @maropu . Sure! |
Today,
|
Github Action already passed in the previous commit and the last one is only adding comment. I'll merge this. |
What changes were proposed in this pull request?
This PR aims to upgrade
Github Action
runner image fromUbuntu 18.04 (LTS)
toUbuntu 20.04 (LTS)
.Why are the changes needed?
ubuntu-latest
inGitHub Action
is stillUbuntu 18.04 (LTS)
.This upgrade will help Apache Spark 3.1+ preparation for vote and release on the latest OS.
This is tested here.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the
Github Action
in this PR.