[SPARK-32804][Launcher][FOLLOWUP] Fix SparkSubmitCommandBuilderSuite test failure without jars #29769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @HyukjinKwon |
f6a3ee7 to
e2b0c6b
Compare
|
ok to test |
HyukjinKwon
approved these changes
Sep 16, 2020
|
Seems that |
|
Test build #128742 has finished for PR 29769 at commit
|
|
retest this please |
|
Test build #128762 has finished for PR 29769 at commit
|
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It's a followup of #29653.
Tests in
SparkSubmitCommandBuilderSuitemay fail if you didn't build first and have jars before test,so if
isTestingwe should set a dummySparkLauncher.NO_RESOURCE.Why are the changes needed?
Fix tests failure.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
mvn clean test (test without jars built first).