Fixes caching related JoinSuite failure #2960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -89,7 +89,7 @@ object TestData { | |||
| LowerCaseData(1, "a") :: | |||
| LowerCaseData(2, "b") :: | |||
| LowerCaseData(3, "c") :: | |||
| LowerCaseData(4, "d") :: Nil) | |||
| LowerCaseData(4, "d") :: Nil).toSchemaRDD | |||
There was a problem hiding this comment.
These two changes are only introduced to calm down IntelliJ syntax highlighting...
|
Test build #22296 has started for PR 2960 at commit
|
|
Test build #22296 has finished for PR 2960 at commit
|
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2860 refines in-memory table statistics and enables broader broadcasted hash join optimization for in-memory tables. This makes
JoinSuitefail when some test suite caches test tabletestDataand gets executed beforeJoinSuite. Because expectedShuffledHashJoins are optimized toBroadcastedHashJoinaccording to collected in-memory table statistics.This PR fixes this issue by clearing the cache before testing join operator selection. A separate test case is also added to test broadcasted hash join operator selection.