Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR][DOCS] Fix ForEachWriter Java example #27671

Closed
wants to merge 1 commit into from
Closed

[MINOR][DOCS] Fix ForEachWriter Java example #27671

wants to merge 1 commit into from

Conversation

roland1982
Copy link

What changes were proposed in this pull request?

Structured streaming documentation example fix

Why are the changes needed?

Currently the java example uses incorrect syntax

Does this PR introduce any user-facing change?

Yes

How was this patch tested?

In IDE

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch -- any others?

@srowen srowen changed the title Fix ForEachWriter Java example [MINOR][DOCS] Fix ForEachWriter Java example Feb 21, 2020
@srowen
Copy link
Member

srowen commented Feb 21, 2020

Jenkins test this please

@roland1982
Copy link
Author

I think I've found some more but can't find them right now. I'll submit another pull request when I find them unless they've been fixed already.

@SparkQA
Copy link

SparkQA commented Feb 21, 2020

Test build #118799 has finished for PR 27671 at commit f07500a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2020
### What changes were proposed in this pull request?
Structured streaming documentation example fix

### Why are the changes needed?
Currently the java example uses incorrect syntax

### Does this PR introduce any user-facing change?
Yes

### How was this patch tested?
In IDE

Closes #27671 from roland1982/foreachwriter_java_example_fix.

Authored-by: roland-ondeviceresearch <roland@ondeviceresearch.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit 9a2cec9)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

Merged to master, branch-3.0 and branch-2.4.

HyukjinKwon pushed a commit that referenced this pull request Feb 22, 2020
### What changes were proposed in this pull request?
Structured streaming documentation example fix

### Why are the changes needed?
Currently the java example uses incorrect syntax

### Does this PR introduce any user-facing change?
Yes

### How was this patch tested?
In IDE

Closes #27671 from roland1982/foreachwriter_java_example_fix.

Authored-by: roland-ondeviceresearch <roland@ondeviceresearch.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@roland1982 roland1982 deleted the foreachwriter_java_example_fix branch February 24, 2020 09:12
sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
### What changes were proposed in this pull request?
Structured streaming documentation example fix

### Why are the changes needed?
Currently the java example uses incorrect syntax

### Does this PR introduce any user-facing change?
Yes

### How was this patch tested?
In IDE

Closes apache#27671 from roland1982/foreachwriter_java_example_fix.

Authored-by: roland-ondeviceresearch <roland@ondeviceresearch.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants