[SPARK-30780][SQL] Empty LocalTableScan should use RDD without partitions #27530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maropu
approved these changes
Feb 11, 2020
|
Test build #118179 has finished for PR 27530 at commit
|
MaxGekk
reviewed
Feb 11, 2020
|
|
||
| private lazy val rdd = sqlContext.sparkContext.parallelize(unsafeRows, numParallelism) | ||
| @transient private lazy val rdd: RDD[InternalRow] = { | ||
| if (rows.isEmpty) { |
There was a problem hiding this comment.
Maybe, unsafeRows.isEmpty? Otherwise I have to look at the difference between unsafeRows and rows.
There was a problem hiding this comment.
This way we avoid materializing the unsafeRows lazy val.
| sqlContext.sparkContext.emptyRDD | ||
| } else { | ||
| val numSlices = math.min(unsafeRows.length, sqlContext.sparkContext.defaultParallelism) | ||
| sqlContext.sparkContext.parallelize(unsafeRows, numSlices) |
There was a problem hiding this comment.
Just in case, does it make sense to put this code (handling empty rows) inside of parallelize?
There was a problem hiding this comment.
parallelize need to respect the numSlices parameter, even if the data is empty.
|
Test build #118260 has finished for PR 27530 at commit
|
HyukjinKwon
approved these changes
Feb 12, 2020
|
Merged to master, and branch-3.0 to consistent with #27400. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Feb 12, 2020
…ions ### What changes were proposed in this pull request? This is a small follow-up for #27400. This PR makes an empty `LocalTableScanExec` return an `RDD` without partitions. ### Why are the changes needed? It is a bit unexpected that the RDD contains partitions if there is not work to do. It also can save a bit of work when this is used in a more complex plan. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Added test to `SparkPlanSuite`. Closes #27530 from hvanhovell/SPARK-30780. Authored-by: herman <herman@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org> (cherry picked from commit b25359c) Signed-off-by: HyukjinKwon <gurwls223@apache.org>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…ions ### What changes were proposed in this pull request? This is a small follow-up for apache#27400. This PR makes an empty `LocalTableScanExec` return an `RDD` without partitions. ### Why are the changes needed? It is a bit unexpected that the RDD contains partitions if there is not work to do. It also can save a bit of work when this is used in a more complex plan. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Added test to `SparkPlanSuite`. Closes apache#27530 from hvanhovell/SPARK-30780. Authored-by: herman <herman@databricks.com> Signed-off-by: HyukjinKwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a small follow-up for #27400. This PR makes an empty
LocalTableScanExecreturn anRDDwithout partitions.Why are the changes needed?
It is a bit unexpected that the RDD contains partitions if there is not work to do. It also can save a bit of work when this is used in a more complex plan.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added test to
SparkPlanSuite.