[SPARK-30627][SQL] Disable all the V2 file sources by default #27348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1728,7 +1728,7 @@ object SQLConf { | |||
| "implementation class names for which Data Source V2 code path is disabled. These data " + | |||
| "sources will fallback to Data Source V1 code path.") | |||
| .stringConf | |||
| .createWithDefault("kafka") | |||
| .createWithDefault("kafka,parquet,orc,json,csv,text,avro") | |||
There was a problem hiding this comment.
Shall we set this alphabetically at this time, @gengliangwang ?
dongjoon-hyun
approved these changes
Jan 24, 2020
|
Test build #117326 has finished for PR 27348 at commit
|
|
Test build #117327 has finished for PR 27348 at commit
|
| @@ -86,6 +87,11 @@ class FileDataSourceV2FallBackSuite extends QueryTest with SharedSparkSession { | |||
| private val dummyReadOnlyFileSourceV2 = classOf[DummyReadOnlyFileDataSourceV2].getName | |||
| private val dummyWriteOnlyFileSourceV2 = classOf[DummyWriteOnlyFileDataSourceV2].getName | |||
|
|
|||
| override protected def sparkConf: SparkConf = | |||
|
Test build #117329 has finished for PR 27348 at commit
|
dongjoon-hyun
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
+1, LGTM again. Thank you, @gengliangwang and @gatorsmile .
All tests passed and the last commit is only indentation changes.
Merged to master.
|
Test build #117334 has finished for PR 27348 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Disable all the V2 file sources in Spark 3.0 by default.
Why are the changes needed?
There are still some missing parts in the file source V2 framework:
FileSourceScanExec. This requires another patch in the data source V2 framework. Tracked by SPARK-30362As we are going to code freeze on Jan 31st, this PR proposes to disable all the V2 file sources in Spark 3.0 by default.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests.