[SPARK-30420][SQL][FOLLOWUP] Remove statement logical plans for namespace commands #27125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @cloud-fan |
cloud-fan
approved these changes
Jan 8, 2020
|
Test build #116278 has finished for PR 27125 at commit
|
|
thanks, merging to master! |
cloud-fan
reviewed
Jan 29, 2021
| DescribeNamespace(catalog, ns, extended) | ||
|
|
||
| case ShowNamespacesStatement(NonSessionCatalogAndNamespace(catalog, ns), pattern) => | ||
| ShowNamespaces(catalog, ns, pattern) |
There was a problem hiding this comment.
We missed the fallback to the v1 ShowDatabasesCommand.
There was a problem hiding this comment.
Let me check, thanks.
There was a problem hiding this comment.
@cloud-fan could you clarify on the fallback?
"show databases" and "show namespaces" were merged by #26006 and both are handled by v2 ShowNamespacesExec.
There was a problem hiding this comment.
Ah I misremember that. So we forgot to add a migration guide for the schema change... (databaseName -> namespace) Anyway it's too late now, let's catch schema changes in the following development work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up to address the following comment: #27095 (comment)
Currently, a SQL command string is parsed to a "statement" logical plan, converted to a logical plan with catalog/namespace, then finally converted to a physical plan. With the new resolution framework, there is no need to create a "statement" logical plan; a logical plan can contain
UnresolvedNamespacewhich will be resolved to aResolvedNamespace. This should simply the code base and make it a bit easier to add a new command.Why are the changes needed?
Clean up codebase.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should cover the changes.