[SPARK-30418][ML] Make FM call super class method extractLabeledPoints #27093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #116103 has finished for PR 27093 at commit
|
srowen
reviewed
Jan 5, 2020
| s" FMClassifier currently only supports binary classification.") | ||
| (label, features) | ||
| } | ||
| val labeledPoint = extractLabeledPoints (dataset, numClasses) |
There was a problem hiding this comment.
Nit: remove extra space before method call
|
Test build #116116 has finished for PR 27093 at commit
|
|
Merged to master |
|
Thank you Sean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
make FMClassifier/Regressor call super class method extractLabeledPoints
Why are the changes needed?
code reuse
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing tests