revert [SPARK-29680][SQL] Remove ALTER TABLE CHANGE COLUMN syntax #27076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #116036 has finished for PR 27076 at commit
|
viirya
reviewed
Jan 2, 2020
| @@ -161,6 +161,9 @@ statement | |||
| | ALTER TABLE table=multipartIdentifier | |||
| (ALTER | CHANGE) COLUMN? column=multipartIdentifier | |||
| (TYPE dataType)? (COMMENT comment=STRING)? colPosition? #alterTableColumn | |||
| | ALTER TABLE table=multipartIdentifier partitionSpec? | |||
| CHANGE COLUMN? | |||
| colName=multipartIdentifier colType colPosition? #hiveChangeColumn | |||
There was a problem hiding this comment.
colName was errorCapturingIdentifier before. We want it to be multipartIdentifier?
There was a problem hiding this comment.
Though it is fine because ResolveSessionCatalog will detect and throw AnalysisException("ALTER COLUMN with qualified column is only supported with v2 tables.").
There was a problem hiding this comment.
This is to be consistent with the other ALTER COLUMN syntax.
viirya
approved these changes
Jan 2, 2020
|
thanks for review, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Revert #26338 , as the syntax is actually the hive style ALTER COLUMN.
This PR brings it back, and make it support multi-catalog:
AlterTableAlterColumnStatementcan't do renaming.Why are the changes needed?
to not break hive compatibility.
Does this PR introduce any user-facing change?
no, as the removal was merged in 3.0.
How was this patch tested?
new parser tests