[SPARK-30406] OneForOneStreamManager ensure that compound operations on shared variables are atomic #27071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mitive fields are not atomic operations. Here when volatile primitive field is incremented or decremented, we run into data loss if threads interleave in steps of update.
HeartSaVioR
reviewed
Jan 2, 2020
common/network-common/src/main/java/org/apache/spark/network/server/OneForOneStreamManager.java
Outdated
Show resolved
Hide resolved
|
Test build #4982 has finished for PR 27071 at commit
|
|
Jenkins retest this please |
|
Test build #116045 has finished for PR 27071 at commit
|
srowen
approved these changes
Jan 3, 2020
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using compound operations as well as increments and decrements on primitive fields are not atomic operations. Here when volatile primitive field is incremented or decremented, we run into data loss if threads interleave in steps of update.
Refer: https://wiki.sei.cmu.edu/confluence/display/java/VNA02-J.+Ensure+that+compound+operations+on+shared+variables+are+atomic
What changes were proposed in this pull request?
Using
AtomicLonginstead oflongWhy are the changes needed?
volatile primitive field is incremented or decremented, we run into data loss if threads interleave in steps of update.
Does this PR introduce any user-facing change?
No
How was this patch tested?
All Existing UT can pass with the Change