[SPARK-30398][ML] PCA/RegressionMetrics/RowMatrix avoid unnecessary computation #27059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #115988 has finished for PR 27059 at commit
|
srowen
reviewed
Dec 31, 2019
| @@ -21,6 +21,7 @@ import scala.annotation.varargs | |||
|
|
|||
| import org.apache.spark.annotation.Since | |||
| import org.apache.spark.api.java.{JavaDoubleRDD, JavaRDD} | |||
| import org.apache.spark.ml.stat.SummaryBuilderImpl._ | |||
There was a problem hiding this comment.
Design wise, can we minimize the places where mllib calls ml? and is it possible to expose this without reaching into the "Impl" class? it looks a little funny
There was a problem hiding this comment.
Just because current aggregator is an inner class org.apache.spark.ml.stat.SummaryBuilderImpl.SummarizerBuffer,
I guess I need to move it outside of SummaryBuilderImpl
minimiaze import of ml
e34c4fb to
a675881
Compare
|
Test build #116005 has finished for PR 27059 at commit
|
|
Test build #116011 has finished for PR 27059 at commit
|
srowen
reviewed
Jan 2, 2020
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
use
.ml.Summarizerinstead of.mllib.MultivariateOnlineSummarizerto avoid computation of unused metricsWhy are the changes needed?
to avoid computation of unused metrics
Does this PR introduce any user-facing change?
No
How was this patch tested?
existing testsuites