[SPARK-30384][WEBUI]Needs to improve the Column name and Add tooltips for the Fair Scheduler Pool Table #27047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@srowen ,@cloud-fan and @HyukjinKwon please review this PR. |
srowen
requested changes
Dec 30, 2019
… the Fair Scheduler Pool Table
srowen
approved these changes
Dec 30, 2019
|
Jenkins test this please |
|
Test build #115966 has finished for PR 27047 at commit
|
|
Test build #115964 has finished for PR 27047 at commit
|
|
cc @srowen all tests passed. |
srowen
reviewed
Dec 31, 2019
HyukjinKwon
approved these changes
Jan 2, 2020
|
Test build #4983 has finished for PR 27047 at commit
|
|
Jenkins retest this please |
|
Test build #116047 has finished for PR 27047 at commit
|
|
@07ARB Could you update the screenshot in the PR description? |
gengliangwang
approved these changes
Jan 2, 2020
|
done |
|
Thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Needs to improve the Column name and tooltips for the Fair Scheduler Pool Table.
Why are the changes needed?
Need to correct SchedulingMode column name to -> 'Scheduling Mode' and tooltips need to add for Minimum Share, Pool Weight and Scheduling Mode (require meaning full Tool tips for the end user to understand.)
Does this PR introduce any user-facing change?
YES
How was this patch tested?
Manual Testing.