-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-7721][INFRA] Run and generate test coverage report from Python via Jenkins #23117
Closed
Closed
Changes from 33 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
d503128
Run and generate test coverage report from Python via Jenkins
HyukjinKwon 135e7ae
Add a logic to remove existing reports
HyukjinKwon 08ab742
Fold the functions
HyukjinKwon 125019d
Debug #1
HyukjinKwon e1a3f9d
Debug 2
HyukjinKwon 3eb7611
Debug 3
HyukjinKwon 88954cd
Revert "Debug #1"
HyukjinKwon 37fcd3c
Revert "Debug 2"
HyukjinKwon dafe7de
Revert "Debug 3"
HyukjinKwon 643246b
Disable DStream tests when PyPy is used with coverage
HyukjinKwon 8133a08
Update run-tests.py
HyukjinKwon 6d46f8c
Make the tests less flaky
HyukjinKwon ad006e7
Skip scala tests for now (debug)
HyukjinKwon 92d74f0
Use SPARK_MATER_SBT_HADOOP_2_7
HyukjinKwon ac6efef
debug 2
HyukjinKwon f34fd8d
debug 3
HyukjinKwon 9ea948d
debug 4
HyukjinKwon 8afab85
Revert "debug 4"
HyukjinKwon 9b4a5b8
Revert "debug 3"
HyukjinKwon 23398d3
Revert "debug 2"
HyukjinKwon f3c7b71
Avoid shell interpretation
HyukjinKwon a88c16f
newlines pretty
HyukjinKwon b7d3cef
Pretty comment
HyukjinKwon c09ddb8
Avoid shell interpreting
HyukjinKwon 0a66669
D'oh!
HyukjinKwon c2412f6
Work around by `symbolic-ref`
HyukjinKwon c660dcf
Fix some comments accordingly
HyukjinKwon 5132334
Fix comments and save Py4J access
HyukjinKwon 0a1216a
Remove workarounds to speed up tests
HyukjinKwon efb0299
typo
HyukjinKwon d4e30f4
Add a badge for PySpark coverage
HyukjinKwon f538410
Match it
HyukjinKwon a1c0601
Adding Shanke as co-author
shaneknapp 426ef11
Fix a typo
HyukjinKwon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,12 +22,16 @@ | |
import unittest | ||
from functools import reduce | ||
from itertools import chain | ||
import platform | ||
|
||
from pyspark import SparkConf, SparkContext, RDD | ||
from pyspark.streaming import StreamingContext | ||
from pyspark.testing.streamingutils import PySparkStreamingTestCase | ||
|
||
|
||
@unittest.skipIf( | ||
"pypy" in platform.python_implementation().lower() and "COVERAGE_PROCESS_START" in os.environ, | ||
"PyPy implementation causes to hang DStream tests forever when Coverage report is used.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, I am not sure but those tests hang forever when coverage is used. |
||
class BasicOperationTests(PySparkStreamingTestCase): | ||
|
||
def test_map(self): | ||
|
@@ -389,6 +393,9 @@ def failed_func(i): | |
self.fail("a failed func should throw an error") | ||
|
||
|
||
@unittest.skipIf( | ||
"pypy" in platform.python_implementation().lower() and "COVERAGE_PROCESS_START" in os.environ, | ||
"PyPy implementation causes to hang DStream tests forever when Coverage report is used.") | ||
class WindowFunctionTests(PySparkStreamingTestCase): | ||
|
||
timeout = 15 | ||
|
@@ -466,6 +473,9 @@ def func(dstream): | |
self._test_func(input, func, expected) | ||
|
||
|
||
@unittest.skipIf( | ||
"pypy" in platform.python_implementation().lower() and "COVERAGE_PROCESS_START" in os.environ, | ||
"PyPy implementation causes to hang DStream tests forever when Coverage report is used.") | ||
class CheckpointTests(unittest.TestCase): | ||
|
||
setupCalled = False | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks this and links to the coverage site https://spark-test.github.io/pyspark-coverage-site/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should leave this link in README.md anyway. Think badge with a link is more effective.