[SPARK-26044][WEBUI]Aggregated Metrics table sort based on executor ID #23024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #98798 has finished for PR 23024 at commit
|
|
Test build #98800 has finished for PR 23024 at commit
|
srowen
reviewed
Nov 14, 2018
core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala
Outdated
Show resolved
Hide resolved
| @@ -70,6 +70,7 @@ private[ui] class ExecutorTable(stage: StageData, store: AppStatusStore) { | |||
| Blacklisted | |||
| </span> | |||
| </th> | |||
| <th>Logs</th> | |||
There was a problem hiding this comment.
What about putting the logs link after the ID column, to stay more consistent? or is it that the Logs column is last in other tables?
There was a problem hiding this comment.
In other tables, like Executors table, Logs column is in the last. That is why I followed the same here.
srowen
reviewed
Nov 14, 2018
core/src/main/scala/org/apache/spark/ui/jobs/ExecutorTable.scala
Outdated
Show resolved
Hide resolved
|
Test build #98835 has finished for PR 23024 at commit
|
|
Test build #98834 has finished for PR 23024 at commit
|
srowen
approved these changes
Nov 15, 2018
|
Merged to master |
|
Thank you @srowen |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Aggregated Metrics table in the stage page is not sorted based on the executorID properly. Because executorID is string and also the logs of the executors are in the same column. In this PR, I created a new column for executor logs. ## How was this patch tested? Before patch:  After patch:  Closes apache#23024 from shahidki31/AggSort. Authored-by: Shahid <shahidki31@gmail.com> Signed-off-by: Sean Owen <sean.owen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Aggregated Metrics table in the stage page is not sorted based on the executorID properly. Because executorID is string and also the logs of the executors are in the same column.
In this PR, I created a new column for executor logs.
How was this patch tested?
Before patch:
After patch:
