-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_COMPRESS only once #22521
Conversation
Test build #96449 has finished for PR 22521 at commit
|
Test build #96495 has finished for PR 22521 at commit
|
Jenkins, retest this please. |
Test build #4350 has started for PR 22521 at commit |
Retest this please. |
@rxin . Could you fill the PR description, too? |
yup; just did |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
+1, LGTM.
nit. Could you add |
Test build #96534 has finished for PR 22521 at commit
|
retest this please |
Test build #96538 has finished for PR 22521 at commit
|
retest this please |
Test build #96554 has finished for PR 22521 at commit
|
seems like our tests are really flaky |
retest this please |
Ya. It's amazing to see 5 different failures in the same PR. :(
|
Test build #96571 has finished for PR 22521 at commit
|
retest this please |
Test build #96585 has finished for PR 22521 at commit
|
Test build #96584 has finished for PR 22521 at commit
|
Test build #4352 has finished for PR 22521 at commit
|
Retest this please. |
Test build #96612 has finished for PR 22521 at commit
|
Test build #4353 has finished for PR 22521 at commit
|
Merged to master/branch-2.4. |
…only once ## What changes were proposed in this pull request? Previously SPARK-24519 created a modifiable config SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_COMPRESS. However, the config is being parsed for every creation of MapStatus, which could be very expensive. Another problem with the previous approach is that it created the illusion that this can be changed dynamically at runtime, which was not true. This PR changes it so the config is computed only once. ## How was this patch tested? Removed a test case that's no longer valid. Closes #22521 from rxin/SPARK-24519. Authored-by: Reynold Xin <rxin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit e702fb1) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…only once ## What changes were proposed in this pull request? Previously SPARK-24519 created a modifiable config SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_COMPRESS. However, the config is being parsed for every creation of MapStatus, which could be very expensive. Another problem with the previous approach is that it created the illusion that this can be changed dynamically at runtime, which was not true. This PR changes it so the config is computed only once. ## How was this patch tested? Removed a test case that's no longer valid. Closes apache#22521 from rxin/SPARK-24519. Authored-by: Reynold Xin <rxin@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
What changes were proposed in this pull request?
Previously SPARK-24519 created a modifiable config SHUFFLE_MIN_NUM_PARTS_TO_HIGHLY_COMPRESS. However, the config is being parsed for every creation of MapStatus, which could be very expensive. Another problem with the previous approach is that it created the illusion that this can be changed dynamically at runtime, which was not true. This PR changes it so the config is computed only once.
How was this patch tested?
Removed a test case that's no longer valid.